Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: Fix scrolling the layertree to the right when adding items #3017

Merged

Conversation

lindakarlovska
Copy link
Contributor

After adding layers to the layer tree, the whole tree is scrolled to the right. If we do that again, the scrollbar is even more expanded.

This PR adjusts the scrollbars at the moment when the new item is added.

Screenshot from 2023-06-05 09-57-28

@lindakarlovska lindakarlovska force-pushed the wxGUI-layer-tree-scrolling-to-the-right branch from 63207fc to 08d989c Compare June 5, 2023 08:27
@lindakarlovska lindakarlovska added bug Something isn't working GUI wxGUI related labels Jun 5, 2023
@lindakarlovska lindakarlovska added this to the 8.3.0 milestone Jun 5, 2023
@petrasovaa petrasovaa requested a review from neteler June 5, 2023 14:25
@petrasovaa petrasovaa modified the milestones: 8.3.0, 8.3.1 Jun 21, 2023
@landam landam modified the milestones: 8.3.1, 8.3.2 Oct 25, 2023
@landam landam modified the milestones: 8.3.2, 8.4.0 Nov 19, 2023
@landam
Copy link
Member

landam commented Nov 19, 2023

@lindakladivova Can you please provide more details how to reproduce this issue? I am unable to reproduce it:

Screencast.from.2023-11-19.12-08-16.webm

@neteler
Copy link
Member

neteler commented Nov 26, 2023

To reproduce:

load:
nc_spm_08_grass7/landsat/

Then display one/some landsat scenes, then click the right mouse button on the legend and the text will be shifted to the left which is not helpful:

image

@landam
Copy link
Member

landam commented Mar 22, 2024

@neteler I tried to reproduce it, but I am still failing:

Screencast.from.2024-03-23.00-54-02.webm

@github-actions github-actions bot added the Python Related code is in Python label Mar 23, 2024
@veroandreo
Copy link
Contributor

@neteler I tried to reproduce it, but I am still failing:

Screencast.from.2024-03-23.00-54-02.webm

I think you need to try with maps with longer map names, see what happens when I unclick a map:

Screencast.from.2024-03-22.21-12-31.webm

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a small change, I think it's fine to merge it.

@petrasovaa petrasovaa merged commit f13a492 into OSGeo:main Apr 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related Python Related code is in Python
Development

Successfully merging this pull request may close these issues.

6 participants