Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/external: Add parson library for JSON #3028

Merged
merged 10 commits into from
Jan 5, 2024

Conversation

cwhite911
Copy link
Contributor

For more details please view discussion at #3019

Issue: #3020

@wenzeslaus wenzeslaus changed the title lib/external/parson: added parson library for JSON lib/external: Add parson library for JSON Jun 6, 2023
@cwhite911
Copy link
Contributor Author

@marisn not sure what I'm missing here. Will you please take a look if I forgot to add something anywhere so this will build.

@neteler
Copy link
Member

neteler commented Jun 15, 2023

PARSON:parson needed also to be registered in include/Make/Grass.make. Fixed in 2c492e2.

@cwhite911
Copy link
Contributor Author

Thanks @neteler! I will write up documentations for this process. Would you rather it be it's own wiki or added to the GRASS Programmer's manual under "Further libraries" after "Miscellaneous Libraries"? I could also add a README.md to the lib/external folder to document the process.

@neteler
Copy link
Member

neteler commented Jun 15, 2023

I'd like:

the GRASS Programmer's manual under "Further libraries"
and
add a README.md to the lib/external folder to document the process.

Thanks.

Copy link
Contributor

@marisn marisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

grasslib.dox Outdated Show resolved Hide resolved
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this section should be here rather than in the readme, but it is not related to this PR and I don't want to delay this any longer.

@neteler neteler added this to the 8.4.0 milestone Aug 16, 2023
@landam landam added the C Related code is in C label Nov 19, 2023
@landam
Copy link
Member

landam commented Nov 19, 2023

@wenzeslaus Please consider merging this PR.

lib/external/README.md Outdated Show resolved Hide resolved
lib/external/README.md Outdated Show resolved Hide resolved
lib/external/README.md Outdated Show resolved Hide resolved
@petrasovaa petrasovaa enabled auto-merge (squash) January 5, 2024 14:24
@petrasovaa petrasovaa merged commit 53c362d into OSGeo:main Jan 5, 2024
23 checks passed
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
* lib/external: Added documentation to adding new external libraries
* Updated GRASS Programmer's manual docs
* update parson from 1.5.2 to 1.5.3 released Oct 31st
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C libraries markdown
Development

Successfully merging this pull request may close these issues.

6 participants