Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.vol.rst: Update parameter names in the example #3073

Merged
merged 5 commits into from
Apr 27, 2024

Conversation

lbartoletti
Copy link
Contributor

Update code example according to the new parameters.

I'm not certain about the overwrite at line 179 v.to.db elevrand option=coor col=x,y but it's required since column are added just before.

Update code example according to the new parameters
marisn
marisn previously approved these changes Jul 6, 2023
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overwrite is not needed when the creation is left to v.to.db, so removing v.db.addcolumn allows to remove the overwrite.

From v.to.db doc:

The column will be created in the table if it doesn't already exist... If the column exists, the --overwrite flag is required to overwrite it.

vector/v.vol.rst/v.vol.rst.html Outdated Show resolved Hide resolved
vector/v.vol.rst/v.vol.rst.html Outdated Show resolved Hide resolved
@wenzeslaus wenzeslaus changed the title Update v.vol.rst.html v.vol.rst: Update parameter names in the example Jul 13, 2023
@neteler neteler added this to the 8.4.0 milestone Aug 16, 2023
@github-actions github-actions bot added vector Related to vector data processing HTML Related code is in HTML module docs labels Jan 19, 2024
@echoix
Copy link
Member

echoix commented Mar 6, 2024

@wenzeslaus Was there any other changes you'd wanted applied here?

@wenzeslaus wenzeslaus merged commit 4ba6eae into OSGeo:main Apr 27, 2024
22 checks passed
@wenzeslaus
Copy link
Member

Thanks @lbartoletti!

@lbartoletti lbartoletti deleted the patch-1 branch April 27, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs HTML Related code is in HTML module vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants