Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI/dbmgr: fix showing attribute column menu #3098

Merged
merged 1 commit into from
Jul 27, 2023
Merged

wxGUI/dbmgr: fix showing attribute column menu #3098

merged 1 commit into from
Jul 27, 2023

Conversation

petrasovaa
Copy link
Contributor

When right-clicking on a column header with non-numerical type in attribute table manager, an error appears:

"/home/vpetras/Projects/grass/code/grass/dist.x86_64-pc-
linux-gnu/gui/wxpython/dbmgr/base.py", line 522, in
OnColumnMenu

popupMenu.Enable(self.popupId["calculate"], False)
wx._core
.
wxAssertionError
:
C++ assertion ""item"" failed at /home/wxpy/wxPython-4.1.1/e
xt/wxWidgets/src/common/menucmn.cpp(793) in Enable():
wxMenu::Enable: no such item

This PR addresses that. The error probably appears only in the newer versions of wxPython, but I am not sure which one broke it.

@petrasovaa petrasovaa added bug Something isn't working GUI wxGUI related backport to 8.3 backport to 7.8 PR needs to be backported to release branch 7.8 labels Jul 24, 2023
@petrasovaa petrasovaa added this to the 8.4.0 milestone Jul 24, 2023
@petrasovaa petrasovaa requested a review from tmszi July 24, 2023 19:07
tmszi
tmszi approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@tmszi tmszi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tested and works as expected.

@tmszi tmszi changed the title wxGUI: fix showing attribute column menu wxGUI/dbmgr: fix showing attribute column menu Jul 25, 2023
@petrasovaa petrasovaa merged commit 1f4d57a into OSGeo:main Jul 27, 2023
19 checks passed
@petrasovaa petrasovaa deleted the fix-menu-disable branch July 27, 2023 18:04
petrasovaa added a commit that referenced this pull request Jul 27, 2023
@petrasovaa
wxGUI: fix showing attribute column menu (#3098)
ecb6fc2
petrasovaa added a commit that referenced this pull request Jul 27, 2023
@petrasovaa
wxGUI: fix showing attribute column menu (#3098)
4f154f9
petrasovaa added a commit to petrasovaa/grass that referenced this pull request Jul 27, 2023
@petrasovaa
wxGUI/dbmgr: fix showing attribute column menu (manual backport of OS…
ea17c74 
…Geo#3098)
petrasovaa added a commit that referenced this pull request Jul 27, 2023
@petrasovaa
wxGUI/dbmgr: fix showing attribute column menu (manual backport of #3098
a186f81 
) (#3103)
@petrasovaa petrasovaa removed the backport to 7.8 PR needs to be backported to release branch 7.8 label Jul 27, 2023
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
@petrasovaa @landam
wxGUI: fix showing attribute column menu (OSGeo#3098)
2271e06
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@petrasovaa @neteler
wxGUI: fix showing attribute column menu (OSGeo#3098)
7a4e4da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmszi tmszi tmszi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@petrasovaa @tmszi