Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/vdidit: fix opening Vector Digitizer settings dialog while editing vector map #3142

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Sep 10, 2023

Describe the bug
Opening vector digitizer settings dialog while editing vector map fails.

To Reproduce
Steps to reproduce the behavior:

  1. Launch Vector Digitizer e.g. g.gui.vdigit geology
  2. From the Vector Digitizer window main toolbar activate Settings tool
  3. See error
Traceback (most recent call last):
  File "/usr/lib64/grass84/gui/wxpython/vdigit/toolbars.py", line 698, in OnSettings
    self.settingsDialog = VDigitSettingsDialog(
  File "/usr/lib64/grass84/gui/wxpython/vdigit/preferences.py", line 48, in __init__
    self._createAttributesPage(notebook)
  File "/usr/lib64/grass84/gui/wxpython/vdigit/preferences.py", line 638, in _createAttributesPage
    column.InsertColumns(
  File "/usr/lib64/grass84/gui/wxpython/gui_core/gselect.py", line 1176, in InsertColumns
    for key, value in columnchoices.item():
AttributeError: 'dict' object has no attribute 'item'. Did you mean: 'items'?

Expected behavior
Opening vector digitizer settings dialog while editing vector map should work.

System description:

  • Operating System: all
  • GRASS GIS version: 8.4.0dev
GRASS nc_basic_spm_grass7/PERMANENT:~ > python3 -c "import sys, wx; print(sys.version); print(wx.version())"
3.10.13 (main, Aug 25 2023, 20:13:27) [GCC 12.3.1 20230526]
4.2.0 gtk3 (phoenix) wxWidgets 3.2.2.1

@tmszi tmszi added bug Something isn't working GUI wxGUI related backport to 8.3 labels Sep 10, 2023
@tmszi tmszi added this to the 8.3.1 milestone Sep 10, 2023
@tmszi tmszi merged commit db8c58f into OSGeo:main Sep 10, 2023
18 checks passed
@tmszi tmszi modified the milestones: 8.3.1, 8.4.0 Sep 10, 2023
@tmszi
Copy link
Member Author

tmszi commented Sep 10, 2023

Backport to 8.3, 8.2 is no needed.

@tmszi tmszi deleted the wxgui-vdidit-fix-open-settings-dialog branch September 10, 2023 18:12
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant