wxGUI/dbmgr: do not modify layer settings if settings have not changed #3143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
The wxGUI Attribute Table Manager adjusts the layer settings even if the settings have not changed while pressing the Modify layer button.
To Reproduce
Steps to reproduce the behavior:
g.gui.dbmgr geology
Expected behavior
The wxGUI Attribute Table Manager don't adjusts the layer settings if the settings have not changed while pressing the Modify layer button.
System description (please complete the following information):
Additional context
Issue related to incorrectly evaluated if condition (layer settings changed), especially line 3863
self.modifyLayerWidgets["database"][1].GetStringSelection()
.Layer Database setting is TextCtrl widget and
self.modifyLayerWidgets["database"][1].GetStringSelection()
code especiallyGetStringSelection()
method return empty string. Correct method for return control value should beGetValue()
.grass/gui/wxpython/dbmgr/base.py
Lines 3860 to 3870 in db8c58f