Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

g.gui.example: fix broken module #3233

Merged
merged 4 commits into from
Apr 30, 2024
Merged

g.gui.example: fix broken module #3233

merged 4 commits into from
Apr 30, 2024

Conversation

pesekon2
Copy link
Contributor

@pesekon2 pesekon2 commented Nov 9, 2023

  • fix instructions in g.gui.example README
  • fix arguments in ExampleMapDialog.dataSizer.Add()
  • ExampleInfoTextManager.textCtrl.SetDefaultStyle() -> SetFont()
  • iteritems() -> items()
  • _getToolbarData(): fix syntax

fix #3232

@pesekon2 pesekon2 added bug Something isn't working GUI wxGUI related Python Related code is in Python backport to 8.3 labels Nov 9, 2023
@pesekon2 pesekon2 self-assigned this Nov 9, 2023
wenzeslaus
wenzeslaus requested changes Nov 9, 2023
View reviewed changes
doc/gui/wxpython/example/README Outdated Show resolved Hide resolved
@landam landam added this to the 8.4.0 milestone Nov 9, 2023
@landam landam requested a review from wenzeslaus March 22, 2024 23:22
@github-actions github-actions bot added the docs label Apr 23, 2024
wenzeslaus
wenzeslaus requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

@pesekon2 pesekon2 merged commit dd1a9b6 into OSGeo:main Apr 30, 2024
26 checks passed
@pesekon2 pesekon2 deleted the g_gui_example_fix branch April 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

@landam landam landam left review comments

Assignees

@pesekon2 pesekon2

Labels
bug Something isn't working docs GUI wxGUI related Python Related code is in Python
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

[Bug] g.gui.example is broken (for many reasons)
5 participants
@pesekon2 @wenzeslaus @landam @neteler @echoix