checks: add -Wpendantic compiler flag to CI builds #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Silence compiler warnings in include/grass/vect/dig_defines.h using compiler #pragma statements.
nilason
changed the title
…into fix_external_warnings
|
Ahgrr, in a fork-rename-and-delete-then-rewording-of-commit operation, I ended up wrongfully pushing this to OSGeo repo. I'm so sorry! |
|
If there are no objections, I will take the liberty to merge this. |
|
@neteler or someone else with access, please delete this branch |
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
Also silence compiler warnings in include/grass/vect/dig_defines.h, caused by code copied from GDAL, using compiler #pragma statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
-Wpedantic(in combination with -Werror) compiler flag in the GCC and macOS CI builds.This supersedes #2899, which was too invasive on the GRASS code. This solution , using
-isystem/path/to/gdal/includes, avoids the compiler issuing warnings for files located there by treating them as system files. This will be quite enough for our purposes.In addition to changes to CI, silencing of compiler warnings (caused by duplicated GDAL code and thus not "fixable") in
include/grass/vect/dig_defines.his made using compiler #pragma statements.