checks: add -Wpendantic compiler flag to CI builds #3245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
-Wpedantic
(in combination with -Werror) compiler flag in the GCC and macOS CI builds.This supersedes #2899, which was too invasive on the GRASS code. This solution , using
-isystem/path/to/gdal/includes
, avoids the compiler issuing warnings for files located there by treating them as system files. This will be quite enough for our purposes.In addition to changes to CI, silencing of compiler warnings (caused by duplicated GDAL code and thus not "fixable") in
include/grass/vect/dig_defines.h
is made using compiler #pragma statements.