Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i.evapo.time: Add example image to manual #3281

Merged
merged 3 commits into from
Dec 27, 2023
Merged

i.evapo.time: Add example image to manual #3281

merged 3 commits into from
Dec 27, 2023

Conversation

YannChemin
Copy link
Contributor

Improved the explaination of the module with a figure and a reference

@YannChemin
Update i.evapo.time.html
3ebee51 
Improved the explaination of the module with a figure and a reference
@neteler
Copy link
Member

neteler commented Dec 2, 2023 •
edited
Loading

@YannChemin: some notes:

  • the file i_evapo_time.png is missing (unfortunately the CI didn't catch that)
  • please (always) write PR titles to be ready for the automated ChangeLog creation using this style:
    module|topic: description
    Otherwise writing the release notes will be a pain. For PR title examples, see the entries e.g. here.
  • also set the milestone and relevant labels.

@neteler neteler mentioned this pull request Dec 2, 2023
Merged
@neteler neteler added this to the 8.4.0 milestone Dec 7, 2023
@echoix echoix changed the title Update i.evapo.time.html i.evapo.time: Add example image to manual Dec 23, 2023
@echoix echoix added manual Documentation related issues info needed Waiting on more info from the submitter labels Dec 23, 2023
@echoix
Copy link
Member

echoix commented Dec 23, 2023 •
edited
Loading

If you need help, reach out to us!

@echoix echoix removed the info needed Waiting on more info from the submitter label Dec 27, 2023
echoix
echoix approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider this a nice addition to improve the docs. If something is missing, it can be changed again later and doesn't regress the current state. I take the liberty to merge to have better docs available as soon as possible.

@echoix echoix merged commit 9b3979c into main Dec 27, 2023
24 checks passed
@echoix echoix deleted the YannChemin-patch-3 branch December 27, 2023 15:18
neteler pushed a commit that referenced this pull request Dec 27, 2023
@YannChemin @echoix @neteler
i.evapo.time: Add example image to manual (#3281)
2e4507f 
* Update i.evapo.time.html

Improved the explaination of the module with a figure and a reference

* Add example of temporal integration (#3280)

Ref: Chemin and Alexandridis 2004 https://ikee.lib.auth.gr/record/270217/files/Chemin-Alexandridis.pdf

---------

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
@neteler neteler modified the milestones: 8.4.0, 8.3.2 Dec 27, 2023
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
@YannChemin @echoix @HuidaeCho
i.evapo.time: Add example image to manual (OSGeo#3281)
e865e42 
* Update i.evapo.time.html

Improved the explaination of the module with a figure and a reference

* Add example of temporal integration (OSGeo#3280)

Ref: Chemin and Alexandridis 2004 https://ikee.lib.auth.gr/record/270217/files/Chemin-Alexandridis.pdf

---------

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

Assignees

@YannChemin YannChemin

Labels
manual Documentation related issues
Projects
None yet
Milestone
8.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@YannChemin @neteler @echoix