Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(deps): Update actions/setup-python action to v5 #3290

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 6, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/setup-python action major v4 -> v5

Release Notes

actions/setup-python (actions/setup-python)

v5

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@neteler
Copy link
Member

neteler commented Dec 6, 2023

From the ChangeLog:

In scope of this release, we update node version runtime from node16 to node20 (actions/setup-python#772). Besides, we update dependencies to the latest versions.

@echoix
Copy link
Member

echoix commented Dec 6, 2023

From the ChangeLog:

In scope of this release, we update node version runtime from node16 to node20 (actions/setup-python#772). Besides, we update dependencies to the latest versions.

There's nothing to worry about. JavaScript actions run directly on the runner, and these have a node version in them. (That's why JavaScript actions can be so fast, they just run on the runner without having to install anything on, and can run on all OSes
that github runners support).
image

Node 20 has been used since October in this very repo since October, when actions/checkout v4 was used.

Node 16 is already EOL, but GitHub managed to start the transition a bit late. They completely skipped node18 (since it is already near the end). (before node 16, javascript actions were run with node 12, and action using node 12 were forced to used node 16 at some point after the transition).

There is nothing "new" added to our workflows. When they say dependencies, it is node/javascript dependencies that are used for that very action.

If you want to wait for me to see if in the megalinter repo I maintain there's any impact, you could, but it is simply a standard action to install software, so I have a high confidence.

The same goes for the add-ons repo.

@landam landam assigned landam and neteler and unassigned landam Dec 7, 2023
Copy link
Member

@landam landam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK for me.

@landam landam added the CI Continuous integration label Dec 7, 2023
@neteler neteler added this to the 8.4.0 milestone Dec 7, 2023
@neteler neteler merged commit 3d11c22 into main Dec 7, 2023
24 checks passed
@renovate renovate bot deleted the renovate/actions-setup-python-5.x branch December 7, 2023 12:50
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants