-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/history: fix execute r/r3.mapcalc module command #3305
Conversation
7d17e6a
to
86a9609
Compare
Rebase and resolve conflicts 86a9609 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like using minus causes some problems for the parsing:
r.mapcalc "test = a - b"
and then using partial parameter name like:
r.mapcalc expr="test = a"
is failing too, but that's probably harder to address.
It may be better to put the parsing function elsewhere, maybe core.utils?
Thanks for catching that. Fixed with c64ab82. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
The only thing is it won't parse correctly the shortened variations of 'expression' parser enables (except 'expr'), so that's a limitation I would just accept for now.
I forgot that it is possible to use a shortened version of the |
I am wondering, would this be a problem in case you use something like:
|
It works as expected. However, I can add it to the func doc test. |
e5f5045
to
a232676
Compare
Fixes #3304.