Tests: Missing shutil import when used inside @unittest.skipIf condition
#3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
changed the title
shutil import when used as a @unittest.skipIfshutil import when used inside @unittest.skipIf condition
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
wenzeslaus
changed the title
shutil import when used inside @unittest.skipIf conditionshutil import when used inside @unittest.skipIf condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to explore a bit more running unittest-based tests with pytest, discovering tests failed on this since shutils wasn’t imported in the file but used in the condition of
@unittest.skipIf. Additionally found by a Python linter.I don’t understand how the two test files could have run correctly and not fail yet with this missing import. Is it actually running in the test suite?