Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/history: add pop-up command menu with an item for delete command from history + history tree refactoring #3342

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

lindakarlovska
Copy link
Contributor

@lindakarlovska lindakarlovska commented Jan 8, 2024

This PR is largely based on #3310.

It implements new functionality with a pop-up command menu with an item for deleting commands from the history log and at the same time also makes some necessary changes in API to ensure better code maintenance in the future.
The API logic for the History panel respects the API used for the Data Catalog.

Main changes in API:

  • Update signal was divided into two signals - addEntryToHistory and removeEntryFromHistory.
  • The main class is the HistoryBrowserTree inheriting from CTreeView (similar logic as in DataCatalogTree)
  • The HistoryBrowser class is used mainly for the widget layout

Fixes:

  • except for editing the history log file when the command is removed from the tree, it also updates the cmd console buffer
  • also addresses the issue when sometimes self._giface does not have to be included as the argument passed to the GConsole and GConsoleWindow constructors ([Bug] g.gui.gmodeler cannot be run due to the history pane #3336)

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple small notes, otherwise it's ready.

@petrasovaa petrasovaa merged commit b0deb48 into OSGeo:main Jan 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related libraries Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants