Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/vector/Vlib: fix count of removed dangles #3348

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

metzm
Copy link
Contributor

@metzm metzm commented Jan 8, 2024

The count of removed dangles in dangles() was wrong, counting all detected dangles. This PR fixes the count of removed dangles.

@metzm metzm added bug Something isn't working vector Related to vector data processing C Related code is in C backport to 8.3 labels Jan 8, 2024
@metzm metzm added this to the 8.4.0 milestone Jan 8, 2024
@metzm metzm requested a review from nilason January 8, 2024 21:15
@github-actions github-actions bot added libraries and removed vector Related to vector data processing labels Jan 8, 2024
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@metzm metzm merged commit 51ec9b2 into OSGeo:main Jan 9, 2024
23 checks passed
@metzm metzm deleted the vlib_dangles branch January 9, 2024 19:41
metzm added a commit that referenced this pull request Jan 9, 2024
Previously, the count of removed dangles reported the count of all dangles. This PR adjusts the count of dangles to only report the count of removed dangles, in accordance with the issued message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C Related code is in C libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants