refactoring: display driver in r_raster.c fixing duplicateExpression warning #3357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a duplicateExpression warning identified by cppcheck in the lib/display/r_raster.c file related to the use of Cairo_Driver. The modifications aim to improve code clarity by refactoring redundant conditions in the Cairo_Driver logic.
Reasons:
Context:
These lines have not been touched for 16 years, and the conditional compilation includes or excludes Cairo_Driver() based on the availability of Cairo during GRASS build. If Cairo is available, it serves as the fallback driver; otherwise, the PNG driver is used.
Testing:
Manual testing has been performed to ensure that the behavior of the Cairo_Driver function remains unchanged. The modified code has undergone style checks using clang-format to maintain standard formatting.