-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: use macOS ARM-based runner #3395
Conversation
Is there a way to see why they are not passing, specifically I am wondering about r.horizon test. |
I planned to create tickets for them, but to give you a head start:
<\details> |
For the record: building now takes about 2.5 min, the run in total some 33 min. Compared to ~7 min and ~79 min. |
The extra core (3 core instead of 2), and the fact that they are fast, seems to help a lot! Even if our tests aren't really parallelized, it's still faster! |
I was literally blown away, the first time I compiled GRASS with a M1 Pro (8-core). Compilation can take advantage of both parallelisation and the sheer speed of Apple's ARM architecture. |
I'm kinda suprised that only two tests failed. Especially for the r3.flow, the numerical differences are quite strange. What do these two modules do differently (or correctly in tests) from the others? If it was only architectural differences, I would have expected way more. |
5e71cbd
to
0c595db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try with this, it'll speed up the feedback loop a fair bit, and is closer to what macOS users would use now. Intel Macs are getting older and older
I agree. And the only "regression" on tests is reported with #3398 (which seems more like an "imperfect" test rather than actual bug). |
Since the regression is already flagged elsewhere, I'm fine going forward with this. That's for your PR! You were the one that made me know about that new change, usually I read GitHub's changelog blog every couple of weeks, and didn't know about it when your PR landed. |
Replace the macOS runner with the new ARM64 based one.
Two tests are not passing, so I put them on the exclusion list.
This will cut the CI run time with approximately 50 %!