Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/history: New button for setting current computational region based on executed commands #3421

Merged
merged 7 commits into from
May 10, 2024

Conversation

lindakarlovska
Copy link
Contributor

@lindakarlovska lindakarlovska commented Feb 13, 2024

This PR enhances the history command info panel by adding the option for setting the current computational region settings to the one active upon the history command execution.

The original command info has only information about the computational region settings:
Screenshot from 2024-03-19 14-16-47

The new proposal adds information on whether the current region is equal to the region from the history or not. In the case that the two settings are not equal, the new button "Set as current region" is added:
Screenshot from 2024-03-19 14-05-38

If settings are equal the panel shows just the info message:
Screenshot from 2024-03-19 14-06-00

@lindakarlovska lindakarlovska self-assigned this Feb 13, 2024
@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python libraries labels Feb 13, 2024
@lindakarlovska lindakarlovska added enhancement New feature or request and removed Python Related code is in Python libraries labels Feb 13, 2024
@lindakarlovska lindakarlovska added this to the 8.4.0 milestone Feb 13, 2024
@github-actions github-actions bot added Python Related code is in Python libraries labels Feb 16, 2024
@lindakarlovska lindakarlovska force-pushed the wxgui-history-choose-run-mode branch 2 times, most recently from 70190f0 to 02d9e77 Compare March 19, 2024 13:15
@lindakarlovska lindakarlovska marked this pull request as ready for review March 19, 2024 13:17
@lindakarlovska lindakarlovska changed the title wxGUI/history: Region settings management wxGUI/history: New button for setting current computational region based on executed commands Mar 21, 2024
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the button towards the top of the region box, otherwise it may be hidden...

@lindakarlovska
Copy link
Contributor Author

Can we move the button towards the top of the region box, otherwise it may be hidden...

Then, the description of the button should be probably changed.. I have changed it to the following:
Screenshot from 2024-04-19 14-03-18

@petrasovaa
Copy link
Contributor

There is a lot of text, but I am not sure how to improve it, @veroandreo any idea?

@lindakarlovska
Copy link
Contributor Author

I am wondering if the arrangement in the bottom panel is sufficiently flexible. I also plan enhance the panel by the error info text (now we have only "failed" written and there is no clue what happened). So maybe we could divide the bottom panel to notebook with tabs: General info, Error info, Region settings and place particular boxes into these tabs?..

@veroandreo
Copy link
Contributor

veroandreo commented Apr 26, 2024

There is a lot of text, but I am not sure how to improve it, @veroandreo any idea?

Well, users need to click over a command to get the region info, so Region settings as it was seems enough to me. What about using also green checks when region setting on command matches the current and red cross when it doesn't? Then with a text box appearing when hovering inform what it means. The amount of text is reduced in that way and the button could say update current region to or simply update current region.

@lindakarlovska
Copy link
Contributor Author

lindakarlovska commented Apr 26, 2024

There is a lot of text, but I am not sure how to improve it, @veroandreo any idea?

Well, users need to click over a command to get the region info, so Region settings as it was seems enough to me. What about using also green checks when region setting on command matches the current and red cross when it doesn't? Then with a text box appearing when hovering inform what it means. The amount of text is reduced in that way and the button could say update current region to or simply update current region.

I like the idea of "Update current region" rather than "Set to .." but I do not understand much of how you think a check should be arranged. Where exactly would you put it, Vero? At the top? I would probably place the check at the top to the left and the button on the right-top side. Do you mean it like this?

@veroandreo
Copy link
Contributor

There is a lot of text, but I am not sure how to improve it, @veroandreo any idea?

Well, users need to click over a command to get the region info, so Region settings as it was seems enough to me. What about using also green checks when region setting on command matches the current and red cross when it doesn't? Then with a text box appearing when hovering inform what it means. The amount of text is reduced in that way and the button could say update current region to or simply update current region.

I like the idea of "Update current region" rather than "Set to .." but I do not understand much of how you think a check should be arranged. Where exactly would you put it, Vero? At the top? I would probably place the check at the top to the left and the button on the right-top side. Do you mean it like this?

I imagined it could go either left or right from the box title, i.e., [check|cross] Region settings or Region settings [check|cross]... Does that make sense?

Though, just below the box title, with something like Region match [check|cross] and the button next to it if it does not match could also do, what do you think?

@lindakarlovska lindakarlovska force-pushed the wxgui-history-choose-run-mode branch from d425565 to ea3b792 Compare May 9, 2024 12:09
@lindakarlovska
Copy link
Contributor Author

Waits for merging #3679 to use proper icons

@lindakarlovska
Copy link
Contributor Author

There is a lot of text, but I am not sure how to improve it, @veroandreo any idea?

Well, users need to click over a command to get the region info, so Region settings as it was seems enough to me. What about using also green checks when region setting on command matches the current and red cross when it doesn't? Then with a text box appearing when hovering inform what it means. The amount of text is reduced in that way and the button could say update current region to or simply update current region.

I like the idea of "Update current region" rather than "Set to .." but I do not understand much of how you think a check should be arranged. Where exactly would you put it, Vero? At the top? I would probably place the check at the top to the left and the button on the right-top side. Do you mean it like this?

I imagined it could go either left or right from the box title, i.e., [check|cross] Region settings or Region settings [check|cross]... Does that make sense?

Though, just below the box title, with something like Region match [check|cross] and the button next to it if it does not match could also do, what do you think?

I implemented the variant with Region match [check|cross] and the button "Update current region" next to it. It is concise, fitting into one row. Thank @veroandreo for the suggestion with the icons, I think it looks really good. :-)

Screenshot from 2024-05-09 14-14-04

I plan to use icons for Check and Cross from #3679 (now there is only the Check icon among current icons)

@lindakarlovska
Copy link
Contributor Author

There is a lot of text, but I am not sure how to improve it, @veroandreo any idea?

Well, users need to click over a command to get the region info, so Region settings as it was seems enough to me. What about using also green checks when region setting on command matches the current and red cross when it doesn't? Then with a text box appearing when hovering inform what it means. The amount of text is reduced in that way and the button could say update current region to or simply update current region.

I like the idea of "Update current region" rather than "Set to .." but I do not understand much of how you think a check should be arranged. Where exactly would you put it, Vero? At the top? I would probably place the check at the top to the left and the button on the right-top side. Do you mean it like this?

I imagined it could go either left or right from the box title, i.e., [check|cross] Region settings or Region settings [check|cross]... Does that make sense?
Though, just below the box title, with something like Region match [check|cross] and the button next to it if it does not match could also do, what do you think?

I implemented the variant with Region match [check|cross] and the button "Update current region" next to it. It is concise, fitting into one row. Thank @veroandreo for the suggestion with the icons, I think it looks really good. :-)

Screenshot from 2024-05-09 14-14-04

I plan to use icons for Check and Cross from #3679 (now there is only the Check icon among current icons)

After using proper icons and minor repositioning..
When regions do not match:
Screenshot from 2024-05-10 10-42-12
When regions match:
Screenshot from 2024-05-10 10-42-32

@lindakarlovska lindakarlovska requested review from petrasovaa and removed request for petrasovaa May 10, 2024 09:08
@petrasovaa petrasovaa merged commit 43be353 into OSGeo:main May 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related libraries Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants