Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.clip: add test for no table #3423

Merged
merged 1 commit into from
Feb 14, 2024
Merged

v.clip: add test for no table #3423

merged 1 commit into from
Feb 14, 2024

Conversation

landam
Copy link
Member

@landam landam commented Feb 14, 2024 •
edited
Loading

This PR extends v.clip module by testing inputs with no table attached. It runs on given combinations:

  • input (no table) + clip
  • input + clip (no table)
  • input (no table) + clip (no table)

See related #3416

@github-actions github-actions bot added vector Related to vector data processing Python Related code is in Python module labels Feb 14, 2024
@landam landam self-assigned this Feb 14, 2024
@landam landam added the tests Related to Test Suite label Feb 14, 2024
@landam landam enabled auto-merge (squash) February 14, 2024 17:01
wenzeslaus
wenzeslaus approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to see this. Maybe a separate class would lead to better messages in case of failure, but this will do the trick.

@landam landam merged commit e8efe36 into OSGeo:main Feb 14, 2024
25 checks passed
@landam landam deleted the v_clip_notable_test branch February 14, 2024 20:29
@neteler neteler added this to the 8.4.0 milestone Feb 15, 2024
@neteler
Copy link
Member

neteler commented Feb 15, 2024

(@landam pls always set a milestone when merging. To re-add them in future is a pain and having them set is great to understand in which version a PR became part of a release. Thx)

jadenabrams100 pushed a commit to ncsu-csc472-spring2024/grass-CI-playground that referenced this pull request Feb 21, 2024
@landam @jadenabrams100
v.clip: add no table test (OSGeo#3423)
b464e65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

Assignees

@landam landam

Labels
module Python Related code is in Python tests Related to Test Suite vector Related to vector data processing
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@landam @neteler @wenzeslaus