Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.dissolve: Fix typo and improve aggregation method description #3429

Merged
merged 2 commits into from
Feb 16, 2024
Merged

v.dissolve: Fix typo and improve aggregation method description #3429

merged 2 commits into from
Feb 16, 2024

Conversation

ecodiv
Copy link
Contributor

@ecodiv ecodiv commented Feb 16, 2024

I think the text is suppose to read "For convenience" rather than "For convince"? A

I think the text is suppose to read "For convencience"  rather than "For convince"?
@github-actions github-actions bot added vector Related to vector data processing HTML Related code is in HTML module docs labels Feb 16, 2024
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing white space.

scripts/v.dissolve/v.dissolve.html Outdated Show resolved Hide resolved
scripts/v.dissolve/v.dissolve.html Outdated Show resolved Hide resolved
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix and clarification. Thanks!

@wenzeslaus
Copy link
Member

I hope that the functionality serves you well. We definitively needs some testing for this before the 8.4 release.

@wenzeslaus wenzeslaus enabled auto-merge (squash) February 16, 2024 15:41
@wenzeslaus wenzeslaus changed the title Update v.dissolve.html v.dissolve: Fix typo and improve aggregation method description Feb 16, 2024
@wenzeslaus wenzeslaus added this to the 8.4.0 milestone Feb 16, 2024
@wenzeslaus wenzeslaus merged commit e6d2a8c into OSGeo:main Feb 16, 2024
22 checks passed
@ecodiv ecodiv deleted the patch-2 branch February 16, 2024 18:43
jadenabrams100 pushed a commit to ncsu-csc472-spring2024/grass-CI-playground that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs HTML Related code is in HTML module vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants