grass.script: Provide env parameter in the g.message API #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the message, verbose and other functions consistent with other wrappers around run_command family calls. While not needed for multiple-mapset situations and parallelization, it is necessary when calls with messages are used without global environment being set and only custom environment available in grass.script.setup. The PR aims at providing the interface, not updating all use cases (except the anticipated changes in grass.script.setup). This does not have any test since the API for that is missing. This will be tested indirectly in the future.
petrasovaa
previously approved these changes
Feb 28, 2024
…uple other function which were misleading or wrong.
|
When I looked at this again, I realized these functions have per-parameter documentation, so I updated that as well. Please review. |
echoix
approved these changes
Mar 3, 2024
|
There is only two non-doc changes, and simply passes down the env arg to run_command. Looks right |
wenzeslaus
added a commit
to wenzeslaus/grass
that referenced
this pull request
May 3, 2024
The original change in PR OSGeo#3439 has None instead of env passed to the error function in the fatal function. This passes the env parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the message, verbose and other functions consistent with other wrappers around run_command family calls. While not needed for multiple-mapset situations and parallelization, it is necessary when calls with messages are used without global environment being set and only a custom (local) environment is available which is the case in grass.script.setup (with #3438).
The PR aims at providing the interface, not updating all use cases (it will be applied for grass.script.setup in #3438).
This does not have any test since the current API does not allow for writing these test. This will be tested indirectly in the future (e.g. by #3438).
While connected to #3438, it is a separate issue more connected to the previous env parameter additions to run_command wrappers, so a separate PR and commit on main seems appropriate.