grass.script: Change insecure mktemp to NamedTemporaryFile #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated mktemp function returns an arbitrary file name to use for a temporary file. However, the application does not immediately create/open this file. This introduces an opportunity for an attacker to interfere with the file to be created. Documentation on tempfile recommends replacing mktemp with NamedTemporaryFile. By doing this, there is no window between getting the temp file name and opening it.
|
Again, thanks for your first contribution here! I hope to see you again, your skillset was useful for all! |
wenzeslaus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed use of deprecated 'tempfile.mktemp' and replaced it with 'NamedTemporaryFile'.
Deprecated mktemp function returns an arbitrary file name to use for a temporary file. However, the application does not immediately create/open this file.
This introduces an opportunity for an attacker to interfere with the file to be created. Documentation on tempfile recommends replacing mktemp with NamedTemporaryFile. By doing this, there is no window between getting the temporary file name and opening it.
Following up on echoix's comment on PR #3436, This was the only instance of
tempfile.mktempI found in this project. There are other uses of a functiontmp_path_factory.mktempin various conftest files, but that is different in that it instantly creates a directory and does not pose the risktempfile.mktempdoes. Additionallytempfile.mkstempwhich is occasionally used is safe as the file is automatically created with secure permissions by default.