utils: fixed shell vulnerability in mkrest.py #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
previously approved these changes
Feb 25, 2024
|
Thanks for your contribution and taking the time to make a clean PR for this! |
|
It will just need to run black to fix the formatting error as shown in the linter logs. In case you already ran black, note that we haven't updated yet to the 2024 style, just by lack of bandwidth to update the code base beforehand. |
My apologies, I not have pre-commit set up when I made my changes and linting escaped my mind. I have fixed the formatting and added the commit to this PR! |
echoix
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a vulnerability in this mkrest.py utilities file, where malformed input in the src_file variable could give an attacker a shell if they escaped the rest of the command. This fix restructures the Popen call to not use shell=True while still retaining the same functionality.