Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: Fix circular dependency warning #3477

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

jef-n
Copy link
Contributor

@jef-n jef-n commented Mar 8, 2024

These from https://github.com/OSGeo/grass/commit/69250e7096fb473b8abab795e95bb1b84a0a6494/checks/22431574413/logs:

$ zgrep Circular logs_21518779849.zip | tee >(head -10 >/dev/tty) | wc -l
2024-03-08T10:25:12.8032190Z make[4]: Circular ../../mswindows/generic.manifest.rc <- ../../mswindows/generic.manifest.rc dependency dropped.
2024-03-08T10:25:13.2727731Z make[3]: Circular ../mswindows/generic.manifest.rc <- ../mswindows/generic.manifest.rc dependency dropped.
2024-03-08T10:27:22.8816153Z make[6]: Circular ../../../mswindows/generic.manifest.rc <- ../../../mswindows/generic.manifest.rc dependency dropped.
2024-03-08T10:28:18.1297727Z make[4]: Circular ../../../mswindows/generic.manifest.rc <- ../../../mswindows/generic.manifest.rc dependency dropped.
2024-03-08T10:28:26.9007408Z make[4]: Circular ../../mswindows/generic.manifest.rc <- ../../mswindows/generic.manifest.rc dependency dropped.
2024-03-08T10:28:27.2913475Z make[4]: Circular ../../mswindows/generic.manifest.rc <- ../../mswindows/generic.manifest.rc dependency dropped.
2024-03-08T10:28:27.6679747Z make[4]: Circular ../../mswindows/generic.manifest.rc <- ../../mswindows/generic.manifest.rc dependency dropped.
2024-03-08T10:28:28.0431812Z make[4]: Circular ../../mswindows/generic.manifest.rc <- ../../mswindows/generic.manifest.rc dependency dropped.
2024-03-08T10:28:29.3249221Z make[4]: Circular ../../mswindows/generic.manifest.rc <- ../../mswindows/generic.manifest.rc dependency dropped.
2024-03-08T10:28:34.3177967Z make[5]: Circular ../../mswindows/generic.manifest.rc <- ../../mswindows/generic.manifest.rc dependency dropped.
163

@github-actions github-actions bot added the windows Microsoft Windows specific label Mar 8, 2024
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand both of the changes. They seem to be correct to me. An input file was renamed to .in since it is modified during build, and the file name is taken from the list of prerequisites from $^. I rely on your expertise to know that it is the correct thing to do, so combining the two, this PR is ok to merge!

@echoix echoix added this to the 8.4.0 milestone Mar 8, 2024
@echoix echoix merged commit b45319c into OSGeo:main Mar 9, 2024
25 checks passed
@echoix
Copy link
Member

echoix commented Mar 9, 2024

@neteler is this something backportable?

neteler pushed a commit that referenced this pull request Mar 9, 2024
@neteler neteler modified the milestones: 8.4.0, 8.3.3 Mar 9, 2024
@neteler
Copy link
Member

neteler commented Mar 9, 2024

@neteler is this something backportable?

Yes, backported to 8.3.

Thanks @jef-n !

@jef-n jef-n deleted the fix-circular-dependency branch March 11, 2024 07:32
@wenzeslaus wenzeslaus changed the title Fix Circular dependency warning make: Fix Circular dependency warning Jun 15, 2024
@wenzeslaus wenzeslaus changed the title make: Fix Circular dependency warning make: Fix circular dependency warning Jun 15, 2024
@neteler neteler modified the milestones: 8.3.3, 8.4.0 Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants