-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.patch: Continuous cats with -e #3508
Conversation
This PR partly addresses https://lists.osgeo.org/pipermail/grass-dev/2024-March/096233.html. In my test, all features were linked to cats. |
This looks like it solves a major part of my issues. Thanks much. I'll try to compile and test very soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improves v.patch and works fine. So I recommend merging. However, there remain additional issues to solve.
@wenzeslaus Is this a GitHub bug? With @cmbarton's approval, I should be able to merge it, but it still says Review required. Weird... |
I think it’s because I no longer have 'official' review to merge authorization. Michael Barton...Sent from my iPadOn Mar 16, 2024, at 10:05 AM, Huidae Cho ***@***.***> wrote:
This improves v.patch and works fine. So I recommend merging. However, there remain additional issues to solve.
@wenzeslaus Is this a GitHub bug? With @cmbarton's approval, I should be able to merge it, but it still says Review required. Weird...
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Yes it is because of that. In these simple cases, when an external expert approves a PR but doesn't have the right permissions, someone else just comes in an approve afterwards, no big deal. |
This PR makes patched categories continuous. Without this PR:
With this PR: