Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Overhaul Coverity Scan #3566

Merged
merged 11 commits into from
Apr 9, 2024
Merged

Conversation

jadenabrams100
Copy link
Contributor

This PR attempts to fix the problems with the previously submitted Coverity Scanning action. Basic building functionality is borrowed from our ubuntu.yml, and Coverity functionality is borrowed from PROJ's coverity-scan.yml.

The needed secrets are:

  • COVERITY_PASSPHRASE: the token used to submit builds.

@github-actions github-actions bot added the CI Continuous integration label Apr 6, 2024
nilason
nilason previously requested changes Apr 7, 2024
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious how this will work, I left some minor suggestions.

.github/workflows/coverity.yml Outdated Show resolved Hide resolved
.github/workflows/coverity.yml Outdated Show resolved Hide resolved
.github/workflows/coverity.yml Outdated Show resolved Hide resolved
.github/workflows/coverity.yml Outdated Show resolved Hide resolved
.github/workflows/coverity.yml Outdated Show resolved Hide resolved
.github/workflows/coverity.yml Outdated Show resolved Hide resolved
.github/workflows/coverity.yml Outdated Show resolved Hide resolved
.github/workflows/coverity.yml Outdated Show resolved Hide resolved
jadenabrams100 and others added 7 commits April 7, 2024 23:21
Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
@echoix echoix requested a review from wenzeslaus April 8, 2024 11:29
@wenzeslaus wenzeslaus dismissed nilason’s stale review April 8, 2024 20:36

Comments resolved.

@wenzeslaus wenzeslaus enabled auto-merge (squash) April 8, 2024 20:39
@wenzeslaus
Copy link
Member

The variables in the Settings are set.

@wenzeslaus wenzeslaus merged commit 88f73e2 into OSGeo:main Apr 9, 2024
27 checks passed
@nilason
Copy link
Contributor

nilason commented Apr 9, 2024

Thanks @jadenabrams100 !

The workflow worked fine https://github.com/OSGeo/grass/actions/runs/8613750220, but some 3 hrs after still no update on Coverity...

See the exemplary commit message 88f73e2: the relevant and potentially important information you first put in in-code comments, is better placed there.

@jadenabrams100
Copy link
Contributor Author

Thank you for example on how to format the commit messages properly! I checked this morning to see if it worked and have been looking into it for the past few hours. I do think it worked properly on our end (given the output from the action looks very similar to PROJ's), so I am not sure why it is not updating on the Coverity website. I sent an email to the Coverity Scan admin explaining our situation and will report back with what he says.

@nilason
Copy link
Contributor

nilason commented Apr 9, 2024

There are two possible reasons:

  1. It needs to be built in debug mode CFLAGS=-g CXXFLAGS=-g
  2. Configure before build with cov-build --dir cov-int make (now it is cov-build --dir cov-int .github/workflows/build_ubuntu-22.04_without_x.sh $HOME/install).

@nilason
Copy link
Contributor

nilason commented Apr 9, 2024

#3572 is an attempt to address this.

@neteler neteler added this to the 8.4.0 milestone Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants