Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpython: fix create new project (location) #3588

Merged
merged 3 commits into from
Apr 12, 2024
Merged

libpython: fix create new project (location) #3588

merged 3 commits into from
Apr 12, 2024

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Apr 12, 2024

Fixes #3587.

@tmszi tmszi added the bug Something isn't working label Apr 12, 2024
@tmszi tmszi added this to the 8.4.0 milestone Apr 12, 2024
@tmszi tmszi self-assigned this Apr 12, 2024
@tmszi tmszi added GUI wxGUI related Python Related code is in Python labels Apr 12, 2024
petrasovaa
petrasovaa requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these changes are fine, I think it should be primarily addressed in create_location() to make it backwards compatible, similarly to how location gets renamed to 'name.

@tmszi
Copy link
Member Author

tmszi commented Apr 12, 2024

While these changes are fine, I think it should be primarily addressed in create_location() to make it backwards compatible, similarly to how location gets renamed to 'name.

Fixed with adaf0d0.

@petrasovaa petrasovaa requested a review from chaedri April 12, 2024 15:22
@chaedri
Copy link
Contributor

chaedri commented Apr 12, 2024

Looks great! I tested too. Thank you @tmszi for catching that.

@petrasovaa petrasovaa changed the title wxGUI/location_wizard: fix create new project (location) libpython: fix create new project (location) Apr 12, 2024
@petrasovaa petrasovaa merged commit f877fb8 into OSGeo:main Apr 12, 2024
26 checks passed
@tmszi tmszi deleted the wxgui-location_wizard-fix-create-new-project branch April 12, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

@chaedri chaedri chaedri approved these changes

Assignees

@tmszi tmszi

Labels
bug Something isn't working GUI wxGUI related libraries Python Related code is in Python
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

[Bug] Creating new project (location) with wxGUI Location wizard fails
3 participants
@tmszi @chaedri @petrasovaa