Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvector/vedit: fix memory leaks #3619

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Apr 17, 2024

Fix some memory leaks in lib/vector/vedit exposed by static analysis.

@nilason nilason added this to the 8.4.0 milestone Apr 17, 2024
@nilason nilason self-assigned this Apr 17, 2024
@github-actions github-actions bot added vector Related to vector data processing C Related code is in C libraries labels Apr 17, 2024
@nilason nilason modified the milestones: 8.4.0, 8.5.0 Apr 30, 2024
lib/vector/vedit/zbulk.c Outdated Show resolved Hide resolved
lib/vector/vedit/vertex.c Outdated Show resolved Hide resolved
lib/vector/vedit/merge.c Outdated Show resolved Hide resolved
@nilason
Copy link
Contributor Author

nilason commented Jun 17, 2024

@lbartoletti Thanks for your review, your points were accurate and I have addressed them and some other I found on the way.

Copy link
Contributor

@lbartoletti lbartoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of goto here!

@echoix
Copy link
Member

echoix commented Jul 4, 2024

@nilason I'll let you set the squash message and merge

@nilason nilason merged commit d1738f6 into OSGeo:main Jul 5, 2024
24 checks passed
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C libraries vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants