Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Define (read|write)_png only #ifdef HAVE_PNG_H #3647

Merged
merged 1 commit into from
Apr 22, 2024
Merged

lib: Define (read|write)_png only #ifdef HAVE_PNG_H #3647

merged 1 commit into from
Apr 22, 2024

Conversation

HuidaeCho
Copy link
Member

This PR addresses #3621 (comment).

@HuidaeCho HuidaeCho requested a review from nilason April 22, 2024 17:05
@HuidaeCho HuidaeCho added C Related code is in C libraries labels Apr 22, 2024
nilason
nilason approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The actual use of these functions is also conditional, e.g.:

grass/lib/pngdriver/read.c

Lines 33 to 36 in 7413740

#ifdef HAVE_PNG_H
else if (G_strcasecmp(p, ".png") == 0)
read_png();
#endif

grass/lib/pngdriver/write.c

Lines 39 to 42 in 7413740

#ifdef HAVE_PNG_H
else if (G_strcasecmp(p, ".png") == 0)
write_png();
#endif

@HuidaeCho HuidaeCho enabled auto-merge (squash) April 22, 2024 18:01
@HuidaeCho HuidaeCho merged commit 96aa1b4 into OSGeo:main Apr 22, 2024
26 checks passed
@HuidaeCho HuidaeCho deleted the pngdriver_wo_libpng branch April 23, 2024 01:02
@neteler neteler added this to the 8.4.0 milestone Apr 23, 2024
nilason pushed a commit to nilason/grass that referenced this pull request Apr 23, 2024
@HuidaeCho @nilason
Define (read|write)_png only #ifdef HAVE_PNG_H (OSGeo#3647)
054dfd0
@wenzeslaus wenzeslaus changed the title Define (read|write)_png only #ifdef HAVE_PNG_H lib: Define (read|write)_png only #ifdef HAVE_PNG_H Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilason nilason nilason approved these changes

Assignees
No one assigned
Labels
C Related code is in C libraries
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HuidaeCho @nilason @neteler