Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g.message: Do not require full gisinit #3686

Merged
merged 1 commit into from
May 4, 2024

Conversation

wenzeslaus
Copy link
Member

The g.message does not need any of the session setup and it can be used during a setup process to report standardized messages to the user. This removes the need to have a full session before running g.message. GISRC is still needed, but the data (file) structures for mapset don't need to exist.

The code is combination of what is in g.proj (the 'no init' call and comment) and g.dirseps (memory mode for GISRC). It is also syncing the corresponding lines in g.proj.

The g.message does not need any of the session setup and it can be used during a setup process to report standardized messages to the user. This removes the need to have a full session before running g.message. GISRC is still needed, but the data (file) structures for mapset don't need to exist.

The code is combination of what is in g.proj (the 'no init' call and comment) and g.dirseps (memory mode for GISRC). It is also syncing the corresponding lines in g.proj.
@github-actions github-actions bot added C Related code is in C module general labels May 3, 2024
@echoix
Copy link
Member

echoix commented May 3, 2024

I approve the concept, but I'm not confident enough in that C part of the code to know the side effects of this. But the code around the diff here is fine for me

@echoix echoix merged commit 06a19bc into OSGeo:main May 4, 2024
26 checks passed
@echoix echoix added this to the 8.4.0 milestone May 4, 2024
@wenzeslaus wenzeslaus deleted the use-no-init-for-g_message branch May 20, 2024 14:32
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request May 21, 2024
The g.message does not need any of the session setup and it can be used during a setup process to report standardized messages to the user. This removes the need to have a full session before running g.message. GISRC is still needed, but the data (file) structures for mapset don't need to exist.

The code is combination of what is in g.proj (the 'no init' call and comment) and g.dirseps (memory mode for GISRC). It is also syncing the corresponding lines in g.proj.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C general module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants