Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grass.script: Automatically parse JSON and CSV in parse_command #3687

Merged
merged 4 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions python/grass/script/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
import string
import random
import shlex
import json
import csv
import io
from tempfile import NamedTemporaryFile
from pathlib import Path

Expand Down Expand Up @@ -543,40 +546,52 @@ def read_command(*args, **kwargs):

def parse_command(*args, **kwargs):
"""Passes all arguments to read_command, then parses the output
by parse_key_val().
by default with parse_key_val().

Parsing function can be optionally given by <em>parse</em> parameter
including its arguments, e.g.
If the command has parameter <em>format</em> and is called with
<em>format=json</em>, the output will be parsed into a dictionary.
Similarly, with <em>format=csv</em> the output will be parsed into
a list of lists (CSV rows).

::

parse_command(..., parse = (grass.parse_key_val, { 'sep' : ':' }))
parse_command("v.db.select", ..., format="json")

or you can simply define <em>delimiter</em>
Custom parsing function can be optionally given by <em>parse</em> parameter
including its arguments, e.g.

::

parse_command(..., delimiter = ':')
parse_command(..., parse=(gs.parse_key_val, {'sep': ':'}))

Parameter <em>delimiter</em> is deprecated.

:param args: list of unnamed arguments (see start_command() for details)
:param kwargs: list of named arguments (see start_command() for details)

:return: parsed module output
"""

def parse_csv(result):
return list(csv.DictReader(io.StringIO(result)))

parse = None
parse_args = {}
if "parse" in kwargs:
if isinstance(kwargs["parse"], tuple):
parse = kwargs["parse"][0]
parse_args = kwargs["parse"][1]
del kwargs["parse"]

if "delimiter" in kwargs:
parse_args = {"sep": kwargs["delimiter"]}
del kwargs["delimiter"]
elif kwargs.get("format") == "json":
parse = json.loads
elif kwargs.get("format") == "csv":
parse = parse_csv

if not parse:
parse = parse_key_val # use default fn
if "delimiter" in kwargs:
parse_args = {"sep": kwargs["delimiter"]}
del kwargs["delimiter"]

res = read_command(*args, **kwargs)

Expand Down
36 changes: 35 additions & 1 deletion python/grass/script/testsuite/test_start_command_functions_nc.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
from grass.gunittest.case import TestCase
from grass.gunittest.main import test

from grass.script.core import start_command, PIPE
from grass.script.core import parse_command, start_command, PIPE
from grass.script.utils import parse_key_val

LOCATION = "nc"

Expand Down Expand Up @@ -49,5 +50,38 @@ def test_multiple_underscores(self):
self.assertIn(b"raster", stderr)


class TestParseCommand(TestCase):
"""Tests parse_command"""

def test_parse_default(self):
result = parse_command("r.info", map="elevation", flags="g")
self.assertTrue(
isinstance(result, dict) and isinstance(result.get("north"), str)
)
result_2 = parse_command("r.info", map="elevation", flags="g", delimiter="=")
self.assertDictEqual(result, result_2)
result_3 = parse_command(
"r.info", map="elevation", flags="g", parse=(parse_key_val, {"sep": "="})
)
self.assertDictEqual(result, result_3)

def test_parse_format_json(self):
result = parse_command(
"r.what", map="elevation", coordinates=(640000, 220000), format="json"
)
self.assertTrue(
isinstance(result, list)
and isinstance(result[0].get("easting"), (int, float))
)
result = parse_command("v.db.select", map="zipcodes", format="json")
wenzeslaus marked this conversation as resolved.
Show resolved Hide resolved

def test_parse_format_csv(self):
reference = parse_command("v.db.select", map="zipcodes", format="json")[
"records"
]
result = parse_command("v.db.select", map="zipcodes", format="csv")
self.assertListEqual(list(reference[0].keys()), list(result[0].keys()))


if __name__ == "__main__":
test()
Loading