Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grass.app: Refactor PATH setup in grass init script and grass.script.setup #3694

Merged
merged 21 commits into from
Jun 23, 2024
Merged

grass.app: Refactor PATH setup in grass init script and grass.script.setup #3694

merged 21 commits into from
Jun 23, 2024

Commits on May 8, 2024

  1. Move path setting code from init script to the package

    @wenzeslaus
    wenzeslaus committed May 8, 2024
    Configuration menu
    Copy the full SHA
    bde9e69 View commit details
    Browse the repository at this point in the history

  2. One common function for dynamic lib path setup

    @wenzeslaus
    wenzeslaus committed May 8, 2024
    Configuration menu
    Copy the full SHA
    3cb93ba View commit details
    Browse the repository at this point in the history

  3. Share all low-level env var setup between the grass init script and g… 

    …rass.script.setup.init
    @wenzeslaus
    wenzeslaus committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5ea520e View commit details
    Browse the repository at this point in the history

  4. Getting config dir needs to be duplicated because of locales, but it … 

    …is now in sync and contains macOS, so getting path to addons needs to deal just with the different dir name, not whole config path.
    @wenzeslaus
    wenzeslaus committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e8294da View commit details
    Browse the repository at this point in the history

  5. Put all the PATH manipulations into one function used in both places.

    @wenzeslaus
    wenzeslaus committed May 8, 2024
    Configuration menu
    Copy the full SHA
    0d83996 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Get encoding when needed for the subprocess output

    @wenzeslaus
    wenzeslaus committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d438a72 View commit details
    Browse the repository at this point in the history

  2. Use same setup order

    @wenzeslaus
    wenzeslaus committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c6cd5eb View commit details
    Browse the repository at this point in the history

  3. Remove need for global vars in grass.app.runtime, cleanup code

    @wenzeslaus
    wenzeslaus committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ab1fac9 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Use subprocess.run and shutil.which as recommended by subprocess doc … 

    …instead of a custom Popen wrapper.
    @wenzeslaus
    wenzeslaus committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d581d94 View commit details
    Browse the repository at this point in the history

  2. Order imports

    @wenzeslaus
    wenzeslaus committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    dffd92b View commit details
    Browse the repository at this point in the history

  3. Merge better subprocess approach with better parametrization approach

    @wenzeslaus
    wenzeslaus committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    02b97b1 View commit details
    Browse the repository at this point in the history

  4. Use text=True and thus Python encoding functions for decoding, this w… 

    …ill be likely right even with Python's UTF-8 mode because it is non-Windows code. This allows us to remove all encode and decode wrappers for lib/init. Using subprocess.run. Clean up man path code and GISBASE usage.
    @wenzeslaus
    wenzeslaus committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    20c6bad View commit details
    Browse the repository at this point in the history

  5. Use shutils.which instead of custom find_exe to detect pagers and bro… 

    …wsers
    @wenzeslaus
    wenzeslaus committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d6e5113 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into refactor-path-setup… 

    …-from-init
    @wenzeslaus
    wenzeslaus committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    014347c View commit details
    Browse the repository at this point in the history

  7. Better naming for package finding function

    @wenzeslaus
    wenzeslaus committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0082201 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. Handle scripts and extrabin on Windows according to OSGeo#3695

    @wenzeslaus
    wenzeslaus committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    f9371a1 View commit details
    Browse the repository at this point in the history

  2. Add documentation

    @wenzeslaus
    wenzeslaus committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    5231e7f View commit details
    Browse the repository at this point in the history

  3. Remove empty file

    @wenzeslaus
    wenzeslaus committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    4f6ecff View commit details
    Browse the repository at this point in the history

  4. Remove unused utils also from Makefile

    @wenzeslaus
    wenzeslaus committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    70d4c16 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Do not set path to GRASS-specific executables on Windows when that's … 

    …set up in the initialization functions.
    @wenzeslaus
    wenzeslaus committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    07c7ab7 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'main' into refactor-path-setup-from-init

    @echoix
    echoix authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    af1697a View commit details
    Browse the repository at this point in the history