library: Add imagery Python library module to grass.script #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninsbl
added
enhancement
wenzeslaus
requested changes
Jun 1, 2024
wenzeslaus
reviewed
Jun 4, 2024
wenzeslaus
reviewed
Jun 4, 2024
wenzeslaus
reviewed
Jun 4, 2024
echoix
previously requested changes
Jun 4, 2024
wenzeslaus
reviewed
Jun 5, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
One last question about this one: does it wire up everything in order for the sphinx docs to be generated correctly for it? For the makefiles it is probably enough, I didn't search more. |
wenzeslaus
previously requested changes
Jul 31, 2024
echoix
reviewed
Jul 31, 2024
Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
This reverts commit 3635ea8.
|
@wenzeslaus would you mind having a look at this if your requested changes are properly addressed and approve or comment? |
echoix
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new imagery module to grass.script. For the time being it has just one function, that returns a dictionary for an imagery group with the contained maps and metadata.
It addresses #3750