Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(deps): Update dependency flake8 to v5 #3815

Merged
merged 2 commits into from
Jun 16, 2024
Merged

CI(deps): Update dependency flake8 to v5 #3815

merged 2 commits into from
Jun 16, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 14, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
flake8 (changelog) 3.9.2 -> 5.0.4 age adoption passing confidence

Release Notes

pycqa/flake8 (flake8)

v5.0.4

Compare Source

v5.0.3

Compare Source

v5.0.2

Compare Source

v5.0.1

Compare Source

v5.0.0

Compare Source

v4.0.1

Compare Source

v4.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@github-actions github-actions bot added the CI Continuous integration label Jun 14, 2024
@echoix
Copy link
Member

echoix commented Jun 14, 2024

@wenzeslaus @neteler The v4 and v5 version of flake8 has no failures, but v6 and v7 does, so we could skip right to v5. Maybe wait until I file another PR tomorrow to see if it gets grouped with pre commit versions too.

@echoix
Copy link
Member

echoix commented Jun 14, 2024

@kritibirda26 would you mind, if you have time, to check if the precommit equivalent of v5.0.4 works correctly too? If so, it'll be the first jump we could do, before having other failures.
Otherwise, there might need to be a bit of work to adapt the configuration of flake8 for the newest version, plus create the PRs to do actual code style fixes.

Copy link
Contributor Author

renovate bot commented Jun 16, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@echoix echoix enabled auto-merge (squash) June 16, 2024 06:03
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-commit run on all files in CI (additional checks) was successful.

@echoix echoix self-assigned this Jun 16, 2024
@echoix echoix added this to the 8.5.0 milestone Jun 16, 2024
@echoix echoix merged commit a92a81d into main Jun 16, 2024
33 checks passed
@kritibirda26
Copy link
Contributor

Hi @echoix, Thanks for the upgrade. It fixed my issue.

@echoix echoix deleted the renovate/flake8-5.x branch June 16, 2024 16:26
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Jun 17, 2024
* CI(deps): Update dependency flake8 to v5

* CI(deps): Update dependency flake8  pre-commit hook to 5.0.4

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants