-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Revert failing cleaning steps in Ubuntu Dockerfile #3830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From our conversation, I assume that one is failing and the two don't do anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you leave RUN apt-get autoremove -y
in docker/ubuntu_wxgui/Dockerfile:241
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with just fixing the failure without touching the Dockerfiles which are working.
Because it wasn't part of the diff of 9f7ecdc that this PR partially reverts to fix the failures. This PR does nothing more. |
The ubuntu_wxgui docker build finished locally on the same fresh cloud IDE as the other 2 changed images. |
I cancelled non-required jobs as they don't have any impact on the mergeability of the PR |
Reverts the part of 9f7ecdc that causes Docker image failure.
Reverts the part of 9f7ecdc that causes Docker image failure.
Built both on a fresh cloud IDE, and also finishing building the untouched ubuntu_wxgui Dockerfile
This fixes only the failures introduced in 9f7ecdc, but nothing else