Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Revert failing cleaning steps in Ubuntu Dockerfile #3830

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Jun 15, 2024

Built both on a fresh cloud IDE, and also finishing building the untouched ubuntu_wxgui Dockerfile

This fixes only the failures introduced in 9f7ecdc, but nothing else

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our conversation, I assume that one is failing and the two don't do anything.

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you leave RUN apt-get autoremove -y in docker/ubuntu_wxgui/Dockerfile:241?

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with just fixing the failure without touching the Dockerfiles which are working.

@echoix
Copy link
Member Author

echoix commented Jun 15, 2024

Why did you leave RUN apt-get autoremove -y in docker/ubuntu_wxgui/Dockerfile:241?

Because it wasn't part of the diff of 9f7ecdc that this PR partially reverts to fix the failures. This PR does nothing more.

@echoix
Copy link
Member Author

echoix commented Jun 15, 2024

The ubuntu_wxgui docker build finished locally on the same fresh cloud IDE as the other 2 changed images.

@echoix echoix added backport to 8.4 PR needs to be backported to release branch 8.4 docker Docker related labels Jun 15, 2024
@echoix echoix added this to the 8.5.0 milestone Jun 15, 2024
@echoix
Copy link
Member Author

echoix commented Jun 15, 2024

I cancelled non-required jobs as they don't have any impact on the mergeability of the PR

@wenzeslaus wenzeslaus merged commit ca553a5 into OSGeo:main Jun 15, 2024
18 of 25 checks passed
neteler pushed a commit that referenced this pull request Jun 15, 2024
Reverts the part of 9f7ecdc that causes Docker image failure.
@neteler neteler removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Jun 15, 2024
@neteler neteler modified the milestones: 8.5.0, 8.4.0 Jun 15, 2024
@echoix echoix deleted the docker-fix-build-failure branch June 15, 2024 17:18
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Jun 17, 2024
Reverts the part of 9f7ecdc that causes Docker image failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants