Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r3.showdspf: fix a typo: case 3 instead of case3 #3867

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

lbartoletti
Copy link
Contributor

A space is missing between the case keyword and the number.

@github-actions github-actions bot added C Related code is in C module raster3d labels Jun 17, 2024
@neteler neteler added this to the 8.5.0 milestone Jun 17, 2024
@neteler
Copy link
Member

neteler commented Jun 17, 2024

Please note that this (very old) module is deactivated and not compiled by default:

r3.retile \

--> not listed

@nilason
Copy link
Contributor

nilason commented Jun 17, 2024

See also

r3.showdspf is not built by default in GRASS 6.2. If you want to build it you
need to ./configure GRASS --with-glw support and run 'make' manually from the
raster3d/r3.showdspf/ source directory.
AFAIK it is the only thing in GRASS 6.2 which uses GLw:
http://article.gmane.org/gmane.comp.gis.grass.devel/19079

@nilason
Copy link
Contributor

nilason commented Jun 17, 2024

How about to move r3.showdspf to https://github.com/OSGeo/grass-addons or delete it?

@neteler
Copy link
Member

neteler commented Jun 26, 2024

I'd suggest to remove it as being entirely outdated. And it's still available from older versions.

@nilason
Copy link
Contributor

nilason commented Aug 2, 2024

I'd suggest to remove it as being entirely outdated. And it's still available from older versions.

@lbartoletti Are you up to change this to remove the module?

@echoix
Copy link
Member

echoix commented Oct 21, 2024

Before having the code removed, I consider it a good idea to fix this missing space, so it is at least that less of a bug when someone wants to dig it up.

I opened an issue to track the remaining steps to finish off this PR and have one less open pending PR ;)

@echoix echoix merged commit 9d699d5 into OSGeo:main Oct 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C module raster3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants