-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r.texture: control the number of threads #3917
Conversation
I believe it should be enough to initialize at the declaration at line 92:
grass/lib/gis/parser_standard_options.c Lines 757 to 770 in 3f30f1b
Something the static analyser apparently didn't catch. |
A user can specify |
Indeed, see eg. grass/raster/r.univar/r.univar_main.c Lines 181 to 182 in 3f30f1b
|
Raising an error for I am open to any choices below.
We just need to make sure the behavior is consistent in every parallelized module. I think now is a good chance to discuss this. |
I have no strong opinion, but I prefer the simplicity of no. 1. |
I like to use |
So
But again, we need to handle it in |
So nproc = 0 would mean something similar to |
Yes. I don't see a reason for two options for serial ( |
Sounds good to me. In my experience, I agree that this should be handled in |
Right, if
|
use helper function to control the number of threads for OpenMP
use helper function to control the number of threads for OpenMP
This PR fixes the coverity issue in #3857. The number of threads should be at least > 1.