Checks: fix flake8 E741 remainder #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
echoix
reviewed
Jun 25, 2024
echoix
approved these changes
Jul 2, 2024
echoix
reviewed
Jul 19, 2024
There was a problem hiding this comment.
There seems to be a regression possibly caused by a change in the number of arguments in the getmaprow functions in this PR, see #3928 (comment)
|
The "l" parameter should be reinserted? If so
|
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
* Rename l to line when using `f.readlines()`. * Remove "l"s from parameters since they aren't used. * Rename "l" to "lx" to assign a lexer object. * Add "# noqa: E741" as renaming parameters won't be applicable in this case. * Rename "l" to "ln" as line number. * Rename "l" to "layer" when looping through the layer list. * Remove E741 for files in the 'locale', `python`, and `scripts` directory. * Rename "ln" to "line_number".
|
Does @nilason have a ctypes related hint here? (if it applies) |
|
If we make a draft PR re-adding the same numbers of parameters, we'll see right away if there is the same error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder of E741 fixes for the "locale", "python", and "scripts" directories. The majority of fixes involved renaming variable names in iterables. The "noqa: E741" was added to "scripts/d.rast.leg/d.rast.leg.py" since it didn't make sense to change just the "l".