-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks: fix flake8 E741 remainder #3928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two questions in two files, all the others are fine as is with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a regression possibly caused by a change in the number of arguments in the getmaprow functions in this PR, see #3928 (comment)
The "l" parameter should be reinserted? If so
|
* Rename l to line when using `f.readlines()`. * Remove "l"s from parameters since they aren't used. * Rename "l" to "lx" to assign a lexer object. * Add "# noqa: E741" as renaming parameters won't be applicable in this case. * Rename "l" to "ln" as line number. * Rename "l" to "layer" when looping through the layer list. * Remove E741 for files in the 'locale', `python`, and `scripts` directory. * Rename "ln" to "line_number".
Does @nilason have a ctypes related hint here? (if it applies) |
If we make a draft PR re-adding the same numbers of parameters, we'll see right away if there is the same error. |
Reminder of E741 fixes for the "locale", "python", and "scripts" directories. The majority of fixes involved renaming variable names in iterables. The "noqa: E741" was added to "scripts/d.rast.leg/d.rast.leg.py" since it didn't make sense to change just the "l".