style: Fix single-line-implicit-string-concatenation violations (ISC001) #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only applies safe fixes with `ruff check --select "ISC001" --fix` in order to limit the review scope.
Separated in another commit for easier review of the changes of the first commit
github-actions
bot
added
GUI
|
There are 11 other non-automatic fixes to apply in another PR |
ninsbl
previously approved these changes
Jul 1, 2024
ninsbl
approved these changes
Jul 1, 2024
cyliang368
pushed a commit
to cyliang368/grass
that referenced
this pull request
Jul 1, 2024
…01) (OSGeo#3943) * style: Fix single-line-implicit-string-concatenation violations (ISC001) Only applies safe fixes with `ruff check --select "ISC001" --fix` in order to limit the review scope. * style: Apply black formatting Separated in another commit for easier review of the changes of the first commit
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 2, 2024
…01) (OSGeo#3943) * style: Fix single-line-implicit-string-concatenation violations (ISC001) Only applies safe fixes with `ruff check --select "ISC001" --fix` in order to limit the review scope. * style: Apply black formatting Separated in another commit for easier review of the changes of the first commit
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
…01) (OSGeo#3943) * style: Fix single-line-implicit-string-concatenation violations (ISC001) Only applies safe fixes with `ruff check --select "ISC001" --fix` in order to limit the review scope. * style: Apply black formatting Separated in another commit for easier review of the changes of the first commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finished creating the new pylint 3 config for #3921. There are too many violations to be useful to file right away.
So here is a first PR that applies a single fix throughout the code base, but it doesn't fix all of them.
The pylint violation in question is
W1404: Implicit string concatenation found in assignment (implicit-str-concat)A similar rule supported by ruff is single-line-implicit-string-concatenation (ISC001), derived from the flake8-implicit-str-concat linter.
This PR only applies safe fixes with
ruff check --select "ISC001" --fixin order to limit the review scope to the obviously correct fixes. These kinds of formatting issues most probably come from different python formatting tool versions throughout the years, like black.I kept applying the fix and then applying black separate in two commits, in order to review the fixes of the first commit only, and simply approving the black formatting.
I'd like for this to not stay pending too long, as there shouldn't be anything to discuss or contest in this.