style: Fixes unnecessary-collection-call (C408) for testsuite #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
vector
Only applies fixes to non-empty collections by `ruff check --select "C408" --unsafe-fixes --output-format=concise --fix --config 'include = ["*/testsuite/**.py"]'` in order to limit the review scope.
Separated in another commit for easier review of only the original changes without formatting
echoix
force-pushed
the
fix-empty-unnecessary-collection-call-testsuite
branch
from
16a4a84 to
e2a3b18
Compare
ninsbl
approved these changes
Jul 1, 2024
cyliang368
pushed a commit
to cyliang368/grass
that referenced
this pull request
Jul 1, 2024
…3947) * style: Fixes unnecessary-collection-call (C408) for testsuite Only applies fixes to non-empty collections by `ruff check --select "C408" --unsafe-fixes --output-format=concise --fix --config 'include = ["*/testsuite/**.py"]'` in order to limit the review scope. * style: Apply black formatting Separated in another commit for easier review of only the original changes without formatting
Merged
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 2, 2024
…3947) * style: Fixes unnecessary-collection-call (C408) for testsuite Only applies fixes to non-empty collections by `ruff check --select "C408" --unsafe-fixes --output-format=concise --fix --config 'include = ["*/testsuite/**.py"]'` in order to limit the review scope. * style: Apply black formatting Separated in another commit for easier review of only the original changes without formatting
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
…3947) * style: Fixes unnecessary-collection-call (C408) for testsuite Only applies fixes to non-empty collections by `ruff check --select "C408" --unsafe-fixes --output-format=concise --fix --config 'include = ["*/testsuite/**.py"]'` in order to limit the review scope. * style: Apply black formatting Separated in another commit for easier review of only the original changes without formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only applies fixes to non-empty collections by
ruff check --select "C408" --unsafe-fixes --output-format=concise --fix --config 'include = ["*/testsuite/**.py"]'in order to limit the review scope.Continuation of #3945, but for fixes that aren't empty collections and only in the testsuite folders, in order to separate it from other changes. Part of the effort to introduce Pylint 3.x for #3921
Uses the fixes provided for ruff rule unnecessary-collection-call (C408) to fix part of Pylint's use-dict-literal / R1735 rule.