Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(temporal): Fixes literal-membership (PLR6201) #3953

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Jun 30, 2024

Concerns Pylint rule "use-set-for-membership / R6201"

Using ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix 'temporal/' 'python/grass/temporal'.

Part of the effort to introduce Pylint 3.x for #3921

Uses the fixes provided for ruff rule literal-membership (PLR6201) to fix part of Pylint's "use-set-for-membership / R6201".

The changes are limited to the temporal-related folders to limit the review scope.

Concerns Pylint rule "use-set-for-membership / R6201"

Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix 'temporal/' 'python/grass/temporal'`.
@echoix echoix added this to the 8.5.0 milestone Jun 30, 2024
@echoix echoix requested a review from ninsbl June 30, 2024 22:47
@github-actions github-actions bot added temporal Related to temporal data processing Python Related code is in Python libraries module labels Jun 30, 2024
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and consistent!

@echoix
Copy link
Member Author

echoix commented Jun 30, 2024

If you are able to review some of the other PRs it would be great! It's a holiday tomorrow, and I'm not finished making individual PRs ;)

@echoix echoix merged commit 614e1e7 into OSGeo:main Jul 1, 2024
26 of 27 checks passed
@echoix echoix deleted the fix-literal-membership-temporal branch July 1, 2024 00:43
cyliang368 pushed a commit to cyliang368/grass that referenced this pull request Jul 1, 2024
Concerns Pylint rule "use-set-for-membership / R6201"

Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix 'temporal/' 'python/grass/temporal'`.
@a0x8o a0x8o mentioned this pull request Jul 1, 2024
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Jul 2, 2024
Concerns Pylint rule "use-set-for-membership / R6201"

Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix 'temporal/' 'python/grass/temporal'`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libraries module Python Related code is in Python temporal Related to temporal data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants