style: Fixes some unnecessary-lambda (PLW0108) #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concerns Pylint rule "unnecessary-lambda / W0108" Using `ruff check --output-format=concise --select PLW0108 --preview --fix --unsafe-fixes`. Didn't apply to cases where it wasn't clear if it was safe
|
To help reviewing, it is useful to know that some of the changes happen to align to a pattern already used inside the same file, like for the "connect()" functions, like here: https://github.com/OSGeo/grass/pull/3956/files#diff-d14bd7d2a6d585d27253c5e579b216708d09a8f4c063c565980e5e7194f5993aR208-R209 |
ninsbl
approved these changes
Jul 2, 2024
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 2, 2024
Concerns Pylint rule "unnecessary-lambda / W0108" Using `ruff check --output-format=concise --select PLW0108 --preview --fix --unsafe-fixes`. Didn't apply to cases where it wasn't clear if it was safe
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jul 23, 2024
Concerns Pylint rule "unnecessary-lambda / W0108" Using `ruff check --output-format=concise --select PLW0108 --preview --fix --unsafe-fixes`. Didn't apply to cases where it wasn't clear if it was safe
echoix
added a commit
to echoix/grass
that referenced
this pull request
Aug 2, 2024
This reverts commit 0cc7cbf.
echoix
added a commit
that referenced
this pull request
Aug 3, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
…3956)" (OSGeo#4127) * Revert "style: Fixes some unnecessary-lambda (PLW0108) (OSGeo#3956)" This reverts commit 0cc7cbf. * ruff: Ignore unnecessary-lambda (PLW0108) in gui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerns Pylint rule "unnecessary-lambda / W0108"
Using
ruff check --output-format=concise --select PLW0108 --preview --fix --unsafe-fixes.Didn't apply to cases where it wasn't clear if it was safe.
Part of the effort to introduce Pylint 3.x for #3921
Uses the fixes provided for ruff rule unnecessary-lambda (PLW0108) to fix part of Pylint's "unnecessary-lambda / W0108".