Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.li manual: Update reference to fragstat paper #4001

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

ecodiv
Copy link
Contributor

@ecodiv ecodiv commented Jul 8, 2024

updated dead URL to fragstat paper by McGarigal et al.

updated dead URL to fragstat paper by McGarigal et al.
@github-actions github-actions bot added raster Related to raster data processing HTML Related code is in HTML module docs labels Jul 8, 2024
@veroandreo veroandreo changed the title Update r.li.html reference to fragstat paper r.li manual: Update reference to fragstat paper Jul 8, 2024
@veroandreo
Copy link
Contributor

@echoix I edited the original title to match the style we use, why does the test fail?

@echoix
Copy link
Member

echoix commented Jul 8, 2024

@echoix I edited the original title to match the style we use, why does the test fail?

@veroandreo because the regex used doesn't expect a space between r.li and manual before the colon.
Also, I'm not quite sure why when changing the title, it adds a new check rather than replacing the existing one. Looks like it gets separated by trigger event.

@neteler
Copy link
Member

neteler commented Jul 9, 2024

the regex used doesn't expect a space between r.li and manual before the colon.

(I'd love to see xxx manual: to be identified as an entry for the manual section in the release notes.)

@echoix
Copy link
Member

echoix commented Jul 9, 2024

the regex used doesn't expect a space between r.li and manual before the colon.

(I'd love to see xxx manual: to be identified as an entry for the manual section in the release notes.)

@wenzeslaus ?

@echoix
Copy link
Member

echoix commented Jul 18, 2024

Let's keep on going, and don't wait for the regex to be adjusted. It will need to be done for a next release, shoving it for later. I opened an issue to track this.

@echoix echoix merged commit 6fb030f into OSGeo:main Jul 18, 2024
22 of 24 checks passed
@neteler neteler modified the milestones: 8.5.0, 8.4.0 Jul 21, 2024
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs HTML Related code is in HTML module raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants