Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks: flake8 F841 (local variable assigned to but never used) fixes in the temporal directory #4229

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

mshukuno
Copy link
Contributor

Description

Flake8 F841 (local variable assigned to but never used) fixes in the temporal directory. Two declarations of unused functions were deleted.

Motivation and context

Changes require resolving a part of Flake8 warnings that are currently ignored. The issue title and number as follows.

  • [Bug] Fix currently ignored Flake8 warnings #1522

How has this been tested?

I've tested them with the gunittest tool in the tool folder.

Types of changes

Two declarations of unused functions were deleted.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as before)

Checklist

I was initially instructed to use 'Checks' for the PR title, however, if any cases need to be changed, please let me know since it isn't listed in release.yml.

  • PR title provides summary of the changes and starts with one of the
    pre-defined prefixes
  • My code follows the code style
    of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@github-actions github-actions bot added temporal Related to temporal data processing Python Related code is in Python module labels Aug 26, 2024
.flake8 Outdated Show resolved Hide resolved
Remove "#local variable..." comments.
@petrasovaa petrasovaa enabled auto-merge (squash) September 12, 2024 14:25
@petrasovaa petrasovaa merged commit 8c23c2e into OSGeo:main Sep 12, 2024
26 checks passed
@neteler neteler added this to the 8.5.0 milestone Sep 12, 2024
@mshukuno mshukuno deleted the flake8-F841-root-temporal branch September 18, 2024 15:17
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module Python Related code is in Python temporal Related to temporal data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants