Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: flake8 F841 (local variable assigned to but never used) fixes in scripts directory part 1 #4238

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

mshukuno
Copy link
Contributor

Description

Flake8 F841 (local variable assigned to but never used) fixes in the scripts directory, specifically, d.polar and r.in.wms.

Motivation and context

Changes require resolving a part of Flake8 warnings that are currently ignored. The issue title and number as follows.

  • [Bug] Fix currently ignored Flake8 warnings #1522

How has this been tested?

  • d.polar: Tested with test_d_polar.py and all passed.

  • r.in.wms: Since this tool doesn't have gunittest, I tested with GUI entered parameters following. Test was successful.
    r.in.wms url="https://tiles.maps.eox.at/wms?" layers=s2cloudless output=sentinel2 format=png

Types of changes

Delete unused variables and entire variable declarations.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as before)

Checklist

  • PR title provides summary of the changes and starts with one of the
    pre-defined prefixes
  • My code follows the code style
    of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Tested using `test_d_polar.py` and all passed.
GUI tested since the `testsuit` file unavailable.
@github-actions github-actions bot added raster Related to raster data processing Python Related code is in Python module display labels Aug 27, 2024
@echoix echoix changed the title checks: flake8 F841 (ocal variable assigned to but never used) fixes in scripts directory part 1 checks: flake8 F841 (ocal variable assigned to but never used) fixes in scripts directory part 1 Aug 27, 2024
@echoix echoix changed the title checks: flake8 F841 (ocal variable assigned to but never used) fixes in scripts directory part 1 checks: flake8 F841 (local variable assigned to but never used) fixes in scripts directory part 1 Aug 27, 2024
@petrasovaa petrasovaa merged commit 57cb4d9 into OSGeo:main Sep 9, 2024
27 of 28 checks passed
@neteler neteler added this to the 8.5.0 milestone Sep 10, 2024
@mshukuno mshukuno deleted the flake8-F841-scripts-1 branch September 18, 2024 15:20
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
display module Python Related code is in Python raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants