Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.ortho.photo: Fix Resource Leak in find_init.c #4388

Merged
merged 13 commits into from
Oct 12, 2024

Conversation

ShubhamDesai
Copy link
Contributor

This pull request addresses resource leak issue identified by coverity scan (CID : 1207903).
Replaced the direct return of G_find_file with a variable (file_exists) to store the result before freeing memory.

@github-actions github-actions bot added C Related code is in C module imagery labels Sep 25, 2024
Shubham Vasudeo Desai and others added 5 commits September 25, 2024 16:12
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
imagery/i.ortho.photo/lib/find_init.c Outdated Show resolved Hide resolved
imagery/i.ortho.photo/lib/find_init.c Outdated Show resolved Hide resolved
Shubham Vasudeo Desai added 2 commits September 25, 2024 17:50
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
imagery/i.ortho.photo/lib/find_init.c Outdated Show resolved Hide resolved
imagery/i.ortho.photo/lib/find_init.c Outdated Show resolved Hide resolved
imagery/i.ortho.photo/lib/find_init.c Outdated Show resolved Hide resolved
imagery/i.ortho.photo/lib/find_init.c Outdated Show resolved Hide resolved
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nilason nilason merged commit 0feea31 into OSGeo:main Oct 12, 2024
26 checks passed
@nilason nilason added this to the 8.5.0 milestone Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C imagery module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants