-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI: Fix F405 error by explicitly importing required modules in iscatt/ #4426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're at it, would you try to have these new imports following the order of what the tool "isort" would do? But please only keep the changes on like new lines, not reordering existing ones too much.
I already tried to change everywhere, but I didn't manage to have a perfectly tuned config. And made hard to read diffs. But we are still tending towards this.
Using isort the/file/path.py
, without any config, does a correct enough job to the new lines+their placement, and will greatly reduce the diff of when we will be applying isort everywhere (I hope in the 1-1.5 year timeframe)
Remember to run black too after choosing the lines to commit. |
I ran |
When adding new imports, or when changing from For this PR, there were two "unexpected" changes where imports not related to this PR got changed. But since they are simple enough, let's just keep it. These changes were the Keep it like this, it's clean that way :) |
Fixed all
F405
andF403
by explicitly importing all the functions. I had to importctypes
separately as well since explicit import ofctypes.c_void_p
wasn't working for some reason. Also updatedctypes.POINTER
toPOINTER
since its being imported.