Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Remove extra semicolons in r.terraflow #4494

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

wenzeslaus
Copy link
Member

With GCC and -Werror=pedantic, the r.terraflow C++ code produces errors because extra semicolons are present after some function definitions. This removes the semincolons and I no longer get 'error: extra ;'.

With GCC and -Werror=pedantic, the r.terraflow C++ code produces errors because extra semicolons are present after some function definitions. This removes the semincolons and I no longer get 'error: extra ;'.
@github-actions github-actions bot added raster Related to raster data processing C++ Related code is in C++ module labels Oct 11, 2024
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One would think -Wpedantic -Werror is the same as -Werror=pedantic

@nilason nilason added this to the 8.5.0 milestone Oct 12, 2024
@nilason nilason merged commit 4cf93d2 into OSGeo:main Oct 12, 2024
26 checks passed
@wenzeslaus wenzeslaus deleted the remove-extra-semicolon branch October 24, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Related code is in C++ module raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants