Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.sim.water: add tests #4551

Merged
merged 2 commits into from
Oct 21, 2024
Merged

r.sim.water: add tests #4551

merged 2 commits into from
Oct 21, 2024

Conversation

petrasovaa
Copy link
Contributor

This adds test for r.sim.water, for default and more complex parameters on a small region. I also added a test for larger region that takes a while, so I am skipping it, but it is useful to run locally.

@petrasovaa petrasovaa added this to the 8.5.0 milestone Oct 18, 2024
@petrasovaa petrasovaa self-assigned this Oct 18, 2024
@github-actions github-actions bot added raster Related to raster data processing Python Related code is in Python module tests Related to Test Suite labels Oct 18, 2024
echoix
echoix approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong, nor other things to check for. I assume the binary files are rasters used for the test? 32KB, 25KB, 37KB and 37KB, so small enough for a git repo.

Having any test is better than no tests at all.

@petrasovaa petrasovaa merged commit 24b398a into OSGeo:main Oct 21, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

Assignees

@petrasovaa petrasovaa

Labels
module Python Related code is in Python raster Related to raster data processing tests Related to Test Suite
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@petrasovaa @echoix