Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Enable checking for E ruff rules from pycodestyle, fixing simple issues #4560

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Oct 20, 2024

This PR enables checking of remaining rules in the E category. It fixes simple issues, E101, E231, E265 and E266.

Ruff rule: https://docs.astral.sh/ruff/rules/multiple-leading-hashes-for-block-comment/

For gui/wxpython/psmap/frame.py, the commented code was present since it was moved from addons to the main repo 13 years ago. At the time, both pair of lines had the same indentation, before PEP8 only formatted the second lines.

File temporal/t.rast.what/t.rast.what.py is ignored for E265 and E266, as it is being addressed in OSGeo#4550
@echoix echoix requested a review from ninsbl October 20, 2024 17:51
@echoix echoix enabled auto-merge (squash) October 20, 2024 17:51
@github-actions github-actions bot added GUI wxGUI related vector Related to vector data processing raster Related to raster data processing Python Related code is in Python libraries module tests Related to Test Suite labels Oct 20, 2024
@echoix echoix merged commit e523163 into OSGeo:main Oct 20, 2024
27 checks passed
@echoix echoix deleted the fix-E-E231-pycodestyle branch October 20, 2024 20:02
@github-actions github-actions bot added this to the 8.5.0 milestone Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related libraries module Python Related code is in Python raster Related to raster data processing tests Related to Test Suite vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants