-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t.rast.univar: allow r-flag combined with zones option #4577
base: main
Are you sure you want to change the base?
Conversation
I don't see a problem with the code changed, but I don't think I understand well the issue. What was the exclusivity between the options protecting before? I think it boils down to the fact that I don't know yet the details of the implementation of an STR3DS vs just a temporal raster STRDS. |
|
@neteler or @veroandreo do you have any thoughts on this maybe? |
Thanks, I better understand why the change works now. The biggest missing piece for me was that zones is like map (that is to be opened), and they can have different regions |
Fix #4576
The library function actually used already a region environment. So it did not have to be added. But the region env was actualy applied redundant to the r-flag for STRDS...
So, now, the region env is only used if r-flag and zones are combined or for STR3DS. If only the r-flag is used, it is propagated to r.univar (for STRDS).